Refactored types for module for project, variableset#29
Closed
KshitijaChoudhari wants to merge 5 commits into
Closed
Refactored types for module for project, variableset#29KshitijaChoudhari wants to merge 5 commits into
KshitijaChoudhari wants to merge 5 commits into
Conversation
iam404
reviewed
Sep 25, 2025
|
|
||
|
|
||
| # Model rebuild functionality for runtime | ||
| def _rebuild_models() -> None: |
Member
There was a problem hiding this comment.
What is the purpose of this forward reference method ?
Contributor
Author
There was a problem hiding this comment.
Yovariable set models are using [TYPE_CHECKING]imports for Organization, Workspace, and Project types. Turns out
No circular imports exist: Organization and Project models don't reference VariableSet back
The types DO exist: Organization, Workspace, and Project are real classes in your codebase
No actual need for TYPE_CHECKING: Since there are no circular imports, you can use direct imports hence removing rebuild_models
Contributor
Author
There was a problem hiding this comment.
Removed type_checking and are now using direct imports
Member
|
Not merging this PR as the changes was done seperately for the whole repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.