Fix workspace variable listing for unpaginated endpoints#183
Closed
kiwigitops wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you for your contribution. But the changes in this PR is superseded by merged PR #182 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace vars endpoints return all rows in a single response and do not include pagination metadata. Routing them through the generic paginated list helper can loop indefinitely when the workspace has at least 100 variables because every requested page returns the same full data set.
This changes variables.list and variables.list_all to issue one request to the workspace variable endpoints and map the returned rows directly.
Closes #181.
Tests