Admin setting - saml, smpt, scim, gh app, token ttl#178
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1fd0b24e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| post-update policy list as the server reports it.""" | ||
| if not valid_string_id(organization): | ||
| raise ValueError(ERR_INVALID_ORG) | ||
| body = {"data": options.to_payload()} |
There was a problem hiding this comment.
For any update() or reset_to_defaults() call, this builds a top-level JSON:API data array of policy resources, but the token TTL PATCH contract (mirrored by go-tfe) expects one organization-token-ttl-policies resource whose attributes contain a token-ttl-policies array. With the current shape the server will reject or ignore the update because it sees an array where the resource object should be, so callers cannot actually change TTL policies through this new API.
Useful? React with 👍 / 👎.
2 participants
No description provided.