Skip to content

Add feature no-code-module and bump user-agent#174

Merged
iam404 merged 3 commits into
next-1.0.0from
no-code
May 27, 2026
Merged

Add feature no-code-module and bump user-agent#174
iam404 merged 3 commits into
next-1.0.0from
no-code

Conversation

@iam404

@iam404 iam404 commented May 27, 2026

Copy link
Copy Markdown
Member

@iam404 iam404 requested a review from a team as a code owner May 27, 2026 09:41
@iam404 iam404 changed the base branch from main to next-1.0.0 May 27, 2026 09:41
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

Run.model_rebuild(raise_errors=False)

P1 Badge Resolve TaskStage before rebuilding Run models

With TaskStage now only imported under TYPE_CHECKING, Run.task_stages remains an unresolved forward reference in the pytfe.models.run module. Calling model_rebuild(raise_errors=False) masks that instead of resolving it, so Runs.list/Runs.read can raise Pydantic's "Run is not fully defined" error when constructing Run objects, even for normal responses that do not include task stages. Import TaskStage at runtime after the circular definitions are available, or rebuild with an explicit namespace.


if TYPE_CHECKING:
from .agent import AgentPool

P2 Badge Keep AgentPool resolvable for Project parsing

Moving AgentPool behind TYPE_CHECKING leaves Project.default_agent_pool as an unresolved Pydantic forward reference at runtime. The project resource calls Project.model_validate(...) in _project_from, so project list/read paths can fail with a "Project is not fully defined" error once this model is imported without a runtime AgentPool symbol. Use a runtime-safe import/rebuild pattern so the annotation is resolved before validation.


registry_provider_platforms: list[RegistryProviderPlatform] | None = Field(
alias="platforms", default=None

P2 Badge Resolve RegistryProviderPlatform at runtime

Because RegistryProviderPlatform is only imported under TYPE_CHECKING, the new typed registry_provider_platforms: list[RegistryProviderPlatform] field cannot be resolved by Pydantic when registry provider versions are parsed. Calls such as RegistryProviderVersions.list/read that return RegistryProviderVersion.model_validate(...) can therefore fail with an incomplete-model error instead of returning version metadata. Rebuild the model with a namespace containing RegistryProviderPlatform or avoid the unresolved runtime annotation.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@iam404 iam404 merged commit 02f8737 into next-1.0.0 May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant