Refactor/agentpool models#166
Merged
Merged
Conversation
…e_ids for allowed and excluded, removed allowed_workspace_policy in models, updated relationships for AgentPool, updated listOptions with parameters
…l resource to add projects, added _parse_agent_pool_from method, removed allowed_workspace_policy in the methods, added valid options in create/update in the models
…updated examples and testcases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the agent pool models and resource implementation to align more closely with the current Terraform Enterprise API shape. This change removes the old allowed_workspace_policy model, adds first-class support for allowed projects/workspaces relationships, and improves agent pool parsing/validation across list, create, read, update, and assignment flows.
It also introduces project assignment support for agent pools, adds agent-pool-specific validation errors, and updates examples/tests to reflect the new model behavior. As part of the refactor, the model layer was adjusted to better handle forward references and circular imports between AgentPool, Project, Workspace, and related models.
Key changes
Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.