Skip to content

feat: support HELM_CHART variable for Cloud Integration Test#48

Open
AbhiMgowda wants to merge 5 commits into
mainfrom
feature/helm-chart-url-support
Open

feat: support HELM_CHART variable for Cloud Integration Test#48
AbhiMgowda wants to merge 5 commits into
mainfrom
feature/helm-chart-url-support

Conversation

@AbhiMgowda

Copy link
Copy Markdown
Collaborator

Summary

Adds a HELM_CHART variable to the Makefile that controls which chart source is used when installing the Boundary Worker chart on EKS, AKS, and GKE clusters.

Previously the install targets (eks-helm, aks-helm, gke-helm) and their full workflows were hardcoded to use . (the local git repo). This meant the integration tests could only be run from a cloned repo — there was no way to test a published/packaged chart URL without manually editing the Makefile.

HOW IT WORKS

  • A single Make variable is declared with a safe default: HELM_CHART ?= .
  • All three cloud install targets now use $(HELM_CHART) instead of . for helm install.
  • All three full workflow targets (eks-full, aks-full, gke-full) explicitly forward the value to their sub-make install step.
  • The variable is read from (in priority order): CLI argument → shell environment variable → .env file → default .

Related

  • Issue:
  • Chart/Component:

Checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • Added/updated tests or validation steps (if applicable)

  • Verified local lint/validation

  • No breaking changes, or clearly documented

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

- Add HELM_CHART ?= . Make variable (defaults to local repo)
- eks-helm, aks-helm, gke-helm use HELM_CHART for helm install
- eks-full, aks-full, gke-full forward HELM_CHART to sub-make targets
- Supports local path, chart tgz URL, or repo/chart reference
- HELM_CHART can be set via env var, .env file, or CLI argument
@AbhiMgowda AbhiMgowda requested a review from a team as a code owner June 8, 2026 04:58
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Reliability Check(s) Results

Target Asset: boundary-worker-helm
Checks Executed: github-actions-sre-reliability-checker-present,github-code-owners-errors,github-secrets-management,metad-has-tags-yaml-file,github-dependabot-security-updates-enabled,github-dependabot-version-updates-enabled,github-code-owners,cv-present,github-dependabot-alerts-enabled,github-code-owners-default-owner,metad-owner-check,tool-use-roam-gha,github-code-scanning-status,github-default-branch-protection-rule,metad-has-deploy-yaml-file,github-secret-push-protection-enabled,github-secret-scanning-enabled,ops-review-active

⚠️ One or more non-blocking checks failed

Failed Check Details:

Note

Click on the check hyperlink for details on how to fix the failed checks.

@AbhiMgowda AbhiMgowda self-assigned this Jun 8, 2026
Comment thread docs/TESTING.md Outdated
Comment thread docs/TESTING.md
Comment thread docs/TESTING.md
Comment thread docs/TESTING.md
Comment thread docs/TESTING.md
Comment thread docs/TESTING.md
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
@AbhiMgowda AbhiMgowda requested a review from YashwanthaGowd June 9, 2026 05:29
Comment thread Makefile Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants