HostDeviceInfo support for various devices#96
Draft
m-ildefons wants to merge 1 commit into
Draft
Conversation
Add HostDeviceInfo struct and related command line flag to the Docker machine driver. This enables the driver to add various host devices (USB, PCI, etc) to a VM. related-to: harvester/harvester#10764 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
|
This pull request is now in conflict. Could you fix it @m-ildefons? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HostDeviceInfo struct and related command line flag to the Docker machine driver. This enables the driver to add various host devices (USB, PCI, etc) to a VM.
Problem:
Rancher Terraform provider can not attach host devices other than vGPUs to VMs.
This is due to the fact that it uses the
.spec.domain.devices.gpusfiel in the VM instance template.Solution:
Add an analogue mechanism for adding host devices in general using the
.spec.domain.devices.hostDevicesfield in the VM instance spec.This works for PCI devices other than GPUs as well as USB devices.
Related Issue(s):
harvester/harvester#10764
Test plan:
TBD.
Additional documentation or context