Skip to content

Documentation issue: .store_root().store_in(Register) doesn't make sense, and is secretly a sliding window. #9375

Description

@mcourteaux

The fact that you even can .store_root().store_in(Register) is bananas. The fact that Halide compiles this as a sliding window optimization without actually store_root() should be documented somewhere. This feels closer to fold_storage() (which it isn't because it's sliding, not looping), than to store_root().

Just dropping this here, as I didn't know that, and discovered that while debugging correctness/sliding_window for some PR. Assigning @abadams because I believe you wrote the sliding window stuff and the accompanying tests. You'll know best what to do.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationMissing, incorrect, or unclear. Spelling & grammar mistakes.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions