Add a Hackpad filter to the funding review queue#687
Merged
Conversation
Reviewers can now narrow the funding queue to Hackpad projects — those whose current (active) mission is the Hackpad mission. Adds a 'Project' filter select (All projects / Hackpad) alongside the existing status/sort/date filters, wired to scope funding requests by the project's active hackpad mission attachment.
Shows a 'Hackpad' pill next to the project title in the funding queue (table and mobile card) for projects whose current mission is Hackpad. The displayed rows' hackpad project ids are loaded in one query to avoid an N+1.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds a Hackpad filter to the hardware funding review queue (
admin/certification/funding_requests#index). Reviewers can now narrow the queue to Hackpad projects — projects whose current (active) mission is the Hackpad mission.How
All projects/Hackpad) next to the existing Status/Sort/Date filters, auto-submitting on change like the others.hackpad— this mirrorsProject#current_mission(a project has at most one active mission attachment, enforced by a unique index).Testing
Verified locally against a seeded scenario: attaching the Hackpad mission to a project makes its funding request appear under the filter (count 1); detaching it drops it back out (count 0). The page renders 200 with the filter control, and the dropdown reflects the active selection.
Note
Low Risk
Admin-only queue filtering and display; no changes to approval logic or the “Start reviewing” flow.
Overview
Adds a Project filter on the hardware funding review queue so reviewers can show All projects or Hackpad only. Hackpad rows are projects whose active mission attachment is the mission with slug
hackpad(same idea asProject#current_mission).The index action reads
project_kind, scopes funding requests to those project ids when Hackpad is selected, and preloads a set of Hackpad project ids for the current page so the table and mobile cards can show a Hackpad pill without per-row mission lookups. Styling adds a lilacship-queue__tagpill on queue rows.Reviewed by Cursor Bugbot for commit 228e53f. Bugbot is set up for automated code reviews on this repo. Configure here.