fix(certification): fix broken changes requested button on YSWS returned projects#683
Open
ObayM wants to merge 1 commit into
Open
fix(certification): fix broken changes requested button on YSWS returned projects#683ObayM wants to merge 1 commit into
ObayM wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project was approved but later returned by YSWS and then sent back by Shipwrights again, the state machine failed to transition because
return_for_changesonly allowed transitions from the :under_review state. This left the project in :approved, which hid the recertification modal and disabled the "Changes requested" button.So I updated the AASM configuration to allow the return_for_changes transition from both :under_review and :approved states.