feat(certification): add Hardware GOI reviewer subcategory#674
Draft
vandorena wants to merge 6 commits into
Draft
feat(certification): add Hardware GOI reviewer subcategory#674vandorena wants to merge 6 commits into
vandorena wants to merge 6 commits into
Conversation
Add a standalone `hardware_guardian_of_integrity` role that splits the YSWS review queue by project category: regular GOIs now see only software projects and Hardware GOIs only hardware projects (Project#hardware?). Admins are unaffected. - YswsPolicy::Scope filters the queue; a centralized User#can_review_project_category? enforces the split on every member action (YSWS show/update/complete/return/commits/report_fraud, devlog_reviews#update, devlog_commits#index) - Role is admin-assignable and audited via the existing PaperTrail role_promoted/role_demoted flow; no migration (roles live in the users.granted_roles array)
Several models carried schema annotations on main that were never regenerated after their migrations — lookout_sessions.devlog_id, plus mission/guide_variant, mission/step_body, post/ship_event, and user. This tripped the `annotaterb models --frozen` CI gate. Regenerate the affected model, test, and fixture annotations to match db/schema.rb. No code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a standalone
hardware_guardian_of_integrityrole that splits the YSWS review queue by project category: regular GOIs now see only software projects and Hardware GOIs only hardware projects (Project#hardware?). Admins are unaffected.AI???
YA CLAUDE