fix: ensure refreshed eTag before update distribution#128
Merged
Conversation
LCaparelli
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with stale ETags during CloudFront distribution sync operations and updates related tests to match the new behavior. The main change ensures that a fresh ETag is always fetched before updating a distribution to avoid
PreconditionFailederrors. The test suite has been updated to reflect the additional call to fetch the latest distribution configuration.CloudFront Distribution Sync Improvements:
internal/cloudfront/repository.go, theSyncmethod now fetches a fresh distribution configuration and ETag immediately before updating, preventingPreconditionFailederrors caused by stale ETags during OAC sync operations.Test Suite Updates:
internal/cloudfront/repository_test.goto expect an additional call toGetDistributionConfig, reflecting the new logic that fetches a fresh ETag before updating:TestSync_CantUpdateDistributionTestSync_CantSaveTagsTestSync_OriginDoesNotExistYetTestSync_OriginAlreadyExistsTestSync_BehaviorDoesNotExistYetTestSync_BehaviorAlreadyExistsTestUpdate_ShouldSyncOneOACAndDeleteOn