Skip to content

Testing bulkrax patches#66

Merged
dolsysmith merged 26 commits into
mainfrom
testing-bulkrax-patches
Mar 4, 2026
Merged

Testing bulkrax patches#66
dolsysmith merged 26 commits into
mainfrom
testing-bulkrax-patches

Conversation

@dolsysmith

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This branch adds Bulkrax support, including patches to enable proper behavior with Fedora 6 and to correct bugs with the importing of embargoed or non-public FileSets associated with public works.

It also adds support for existing GWSS work types: GwEtd, GwWork, and GwJournalIssue.

Rspec tests are not yet working for the Bulkrax behavior, though the additional work types do have basic test coverage.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Under spec/fixtures, there is a zipped import file for use in manual Bulkrax testing: testing_bulkrax_import.zip

  1. Create examples of a GwWork, GwEtd, and GwJournalIssue in the UI, with attached files.
  2. Confirm that permissions/embargoes can be set at both work and file level, and that these display properly.
  3. Run a Bulkrax import from the UI dashboard, using the included zip file.
  4. Verify (in the logs for the worker container and in the Bulkrax importer dashboard) that the import completes without failures.
  5. Verify that permissions and embargoes are set correctly. (The titles of the works and files are designed to aid in verification.)

Note that this branch contains work in progress on a CLI task for invoking and managing Bulkrax imports, but since this code doesn't have other dependencies (apart from Bulkrax), I thought it best to get everything merged now, so that it doesn't get out of sync again.

@alepbloyd

Copy link
Copy Markdown
Collaborator

@dolsysmith

I completed the manual testing and import and I think everything is looking good, and I can independently update the embargoes on a work and the associated files. Couple of clarifying questions on the zip file and the naming of the imported works though.

In the examples below, it's difficult to tell based on the naming convention whether the access settings are being applied as intended, because I know for some the work itself should have different settings from the attached documents. Would it be too much trouble to adjust the titles of the imported demo works in the zip to be something along the lines of ETD - Work Public, File Embargoed, or ETD - Work Authenticated, File Private, etc etc.?

Screenshot 2026-02-27 at 11 55 43 AM Screenshot 2026-02-27 at 11 57 57 AM

@dolsysmith

Copy link
Copy Markdown
Contributor Author

Thanks, @alepbloyd -- great point. I updated the test import so that the work titles now reflect the intended visibility of work and files.

@alepbloyd

Copy link
Copy Markdown
Collaborator

Thanks! I'll rerun the import later this afternoon and will let you know if I have other questions.

@alepbloyd alepbloyd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just checked with the new names and everything on the import is working as described.

@kerchner

kerchner commented Mar 2, 2026

Copy link
Copy Markdown
Member

@dolsysmith The fixture import worked fine and had all of the expected permissions. I noticed that you also added a pair of thor tasks, but I see your note above that this isn't ready for testing yet.

@kerchner kerchner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixture file works, and the imported works have the correct permissions, but note that I'm only able to unzip it on the Ubuntu server; unzip fails when on the Mac.

@dolsysmith

Copy link
Copy Markdown
Contributor Author

@dolsysmith The fixture import worked fine and had all of the expected permissions. I noticed that you also added a pair of thor tasks, but I see your note above that this isn't ready for testing yet.

Thanks, @kerchner! The thor tasks are a work in progress -- I just wanted to get the rest of the branch merged while I continue to work on those.

@dolsysmith dolsysmith merged commit 0d0faeb into main Mar 4, 2026
1 check passed
@dolsysmith dolsysmith deleted the testing-bulkrax-patches branch March 4, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install Bulkrax

3 participants