T36 limit admin routes#64
Draft
alepbloyd wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Just chipping away at the MVP tickets. This handles the redirection of non-admin users away from /sidekiq and adds a non-rails 404 page.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Run tests, should be 205 examples, 1 pending, 0 failing.
To manually test 404 page, visit an invalid URL and ensure you don't see the rails error page - should see basic 404 page instead.
To manually test sidekiq access - sign in as admin user and visit /sidekiq, you should see the sidekiq dashboard. Sign out and visit /sidekiq, and you should see a 404 page.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?