Skip to content

feat: add DEFAULT_FAREWELL constant to constants module (BL-019) - #16

Merged
gwickman merged 1 commit into
mainfrom
feat/v005/add-default-farewell-constant
May 13, 2026
Merged

gwickman merged 1 commit into
mainfrom
feat/v005/add-default-farewell-constant

Conversation

@gwickman

Copy link
Copy Markdown
Owner

Add DEFAULT_FAREWELL: str = "goodbye" as a module-level constant in
src/test_target_2/constants.py alongside the existing DEFAULT_HELLO_TARGET,
providing a minimal-but-real probe target for v005 test rig validation.

Add two test functions to tests/test_constants.py:

  • test_default_farewell_value(): verifies constant value equals "goodbye"
  • test_default_farewell_type(): verifies constant is type str

All quality gates pass: ruff check, ruff format, mypy, pytest.

Backlog: BL-019
Validation: README discipline migration (BL-945, BL-946, BL-947, BL-949)

Add DEFAULT_FAREWELL: str = "goodbye" as a module-level constant in
src/test_target_2/constants.py alongside the existing DEFAULT_HELLO_TARGET,
providing a minimal-but-real probe target for v005 test rig validation.

Add two test functions to tests/test_constants.py:
- test_default_farewell_value(): verifies constant value equals "goodbye"
- test_default_farewell_type(): verifies constant is type str

All quality gates pass: ruff check, ruff format, mypy, pytest.

Backlog: BL-019
Validation: README discipline migration (BL-945, BL-946, BL-947, BL-949)
@gwickman
gwickman merged commit 56c5c41 into main May 13, 2026
1 check passed
@gwickman
gwickman deleted the feat/v005/add-default-farewell-constant branch May 13, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant