Skip to content

fix(#2294): make EnsureProvider idempotent via delete-and-recreate#15

Open
guyoron1 wants to merge 7 commits into
mainfrom
fix/2294-idempotent-ensure-provider
Open

fix(#2294): make EnsureProvider idempotent via delete-and-recreate#15
guyoron1 wants to merge 7 commits into
mainfrom
fix/2294-idempotent-ensure-provider

Conversation

@guyoron1

@guyoron1 guyoron1 commented Jun 16, 2026

Copy link
Copy Markdown
Owner

EnsureProvider called openshell provider create and treated any error as a hard failure. When a provider already existed from a prior run, the AlreadyExists error blocked subsequent runs, requiring manual cleanup between iterations.

Now when the create command fails with AlreadyExists, the function deletes the existing provider and recreates it with current credentials.

Also extracted a redactSecrets helper to reduce duplication in error formatting paths.

Mirrored from upstream PR #2296

@guyoron1

guyoron1 commented Jun 16, 2026

Copy link
Copy Markdown
Owner Author

/fs quality

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:48 AM UTC · Completed 8:57 AM UTC
Commit: ee6f7cd · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review

Reason: stale-head

The review agent reviewed commit 67a33b44cb003a4bd190ef14c821baade5a6ed32 but the PR HEAD is now ede0f9169e13a1ea057b5e49951e6dc0d6f20850. This review was discarded to avoid approving unreviewed code.

Previous run

Review

Reason: stale-head

The review agent reviewed commit 639a409049c0e18938a1556172af501459b2a3f5 but the PR HEAD is now 67a33b44cb003a4bd190ef14c821baade5a6ed32. This review was discarded to avoid approving unreviewed code.

Previous run (2)

Review

Reason: stale-head

The review agent reviewed commit 92bc404ab990ff209fdf7b75b8863e4e595a6871 but the PR HEAD is now 639a409049c0e18938a1556172af501459b2a3f5. This review was discarded to avoid approving unreviewed code.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:59 AM UTC · Completed 9:10 AM UTC
Commit: ee6f7cd · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:11 AM UTC · Completed 9:21 AM UTC
Commit: ee6f7cd · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

/fs-review

QualityFlow and others added 2 commits June 16, 2026 09:24
Add test output for GH-15 [skip ci]
d2d3261 
Generated 10 tests from STD YAML (7 scenarios):
- Go/Ginkgo v2: 6 functional tests (problem document verification)
- Python/pytest: 4 tests (content validation with parametrized topics)
@guyoron1
Add QualityFlow tests for GH-15
890172f 
Replaces intermediate pipeline artifacts with organized test files.

Total: 2 test files → qf-tests/GH-15/
Jira: GH-15
[skip ci]
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

QualityFlow Pipeline Summary

Stage Agent Status
1 STP Builder ✅
2 STP Reviewer ✅
3 STP Refiner ✅
4 STD Builder ✅
5 STD Reviewer ✅
6 STD Refiner ✅
7 Test Generator ✅

Test Output

Language Count Location
Go 1 files qf-tests/GH-15/go/
Python 1 files qf-tests/GH-15/python/

Issue: GH-15

Generated by QualityFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guyoron1