fix(gcp): remove the project from the number call by guyoron1 · Pull Request #11 · guyoron1/fullsend

guyoron1 · 2026-06-15T14:40:21Z

I found that doing this removed the need to enable cloudresourcemanager permissions on the GCP project.

Mirrored from upstream PR #2231

guyoron1 · 2026-06-15T14:40:37Z

/fs quality

fullsend-ai-review · 2026-06-15T14:42:01Z

🤖 Finished Review · ✅ Success · Started 2:42 PM UTC · Completed 2:48 PM UTC
Commit: 4365b3d · View workflow run →

fullsend-ai-review · 2026-06-15T14:48:11Z

Review

Reason: stale-head

The review agent reviewed commit 69a77055df8ba9c049cc7cf7c8385612b50c2d17 but the PR HEAD is now 9f8e63a7eaedbba14fb03f5412012857fccaa42b. This review was discarded to avoid approving unreviewed code.

Previous run

Review

Reason: stale-head

The review agent reviewed commit ff42f77ff6d16bf9fc0dc282e4041d188b6eea43 but the PR HEAD is now 69a77055df8ba9c049cc7cf7c8385612b50c2d17. This review was discarded to avoid approving unreviewed code.

Previous run (2)

Review

Findings

Critical

[compilation error] internal/dispatch/gcf/gcp.go:893 — The diff sets noQuotaClient.QuotaProject = "" but gcp.Client (defined in internal/gcp/client.go) has no QuotaProject field. The struct contains only httpClient *http.Client and tokenFunc func(...). This code will not compile.
Remediation: Either add a QuotaProject string field to gcp.Client in internal/gcp/client.go and update DoRequest to set the x-goog-user-project header when that field is non-empty, or take a different approach to omitting the quota project header (e.g., a DoRequestWithoutQuotaProject method or passing options to DoRequest).
[logic error / no-op mechanism] internal/dispatch/gcf/gcp.go:894 — Even if a QuotaProject field were added to gcp.Client, the DoRequest method (internal/gcp/client.go:70-91) never reads any such field and never sets the x-goog-user-project HTTP header. Clearing the field on the copy would have no effect on the outgoing request — the stated goal of avoiding quota-project attribution would not be achieved.
Remediation: Modify DoRequest (or add a variant) to conditionally set the x-goog-user-project header based on the QuotaProject field value, so that clearing the field actually changes the wire-level request.

Low

[struct-copy-pattern] internal/dispatch/gcf/gcp.go:891 — The shallow copy pattern (noQuotaClient := *c.Client) is unconventional in this file. While safe in this specific case (the shared *http.Client is concurrency-safe and not mutated), consider adding explicit support in gcp.Client for omitting the quota project header rather than copying and mutating the struct.

fullsend-ai-review

See the review comment for full details.

fullsend-ai-review · 2026-06-15T14:48:12Z

+	// CRM is a global API — omit x-goog-user-project to avoid requiring
+	// the API to be enabled on the target project.
+	noQuotaClient := *c.Client
+	noQuotaClient.QuotaProject = ""


[critical] compilation error

The diff sets noQuotaClient.QuotaProject but gcp.Client (defined in internal/gcp/client.go) has no QuotaProject field. The struct contains only httpClient *http.Client and tokenFunc. This code will not compile.

Suggested fix: Add a QuotaProject string field to gcp.Client and update DoRequest to set the x-goog-user-project header when non-empty, or take a different approach.

fullsend-ai-review · 2026-06-15T14:48:12Z

+	// the API to be enabled on the target project.
+	noQuotaClient := *c.Client
+	noQuotaClient.QuotaProject = ""
+	resp, err := noQuotaClient.DoRequest(ctx, http.MethodGet, reqURL, "")


[critical] logic error / no-op mechanism

Even if QuotaProject were added to gcp.Client, DoRequest never reads it or sets the x-goog-user-project HTTP header. Clearing the field would have no effect on the outgoing request.

Suggested fix: Modify DoRequest to conditionally set x-goog-user-project based on the QuotaProject field value.

fullsend-ai-review · 2026-06-15T14:48:12Z


-	resp, err := c.Client.DoRequest(ctx, http.MethodGet, reqURL, "")
+	// CRM is a global API — omit x-goog-user-project to avoid requiring
+	// the API to be enabled on the target project.


[low] struct-copy-pattern

The shallow copy pattern is unconventional in this file. Consider adding explicit support in gcp.Client for quota-project-free requests.

Suggested fix: Add a dedicated method or option to gcp.Client for quota-project-free requests.

fullsend-ai-review · 2026-06-15T14:50:06Z

🤖 Finished Review · ✅ Success · Started 2:50 PM UTC · Completed 2:59 PM UTC
Commit: 4365b3d · View workflow run →

fullsend-ai-review · 2026-06-15T14:59:39Z

/fs-review

fullsend-ai-review · 2026-06-15T15:01:22Z

🤖 Finished Review · ✅ Success · Started 3:01 PM UTC · Completed 3:12 PM UTC
Commit: 4365b3d · View workflow run →

fullsend-ai-review · 2026-06-15T15:12:04Z

/fs-review

Generated 7 Go e2e test functions from STD YAML for the "Remove Quota Project from GCP Project Number Lookup" fix. Test coverage: 7/7 STD scenarios (TS-GH-11-001 through TS-GH-11-007) Framework: Go testing + testify Build tag: e2e Known issue: gcp.Client lacks QuotaProject field (compilation prerequisite).

Replaces intermediate pipeline artifacts with organized test files. Total: 1 test files → qf-tests/GH-11/ Jira: GH-11 [skip ci]

github-actions · 2026-06-15T15:22:07Z

QualityFlow Pipeline Summary

Stage	Agent	Status
1	STP Builder	✅
2	STP Reviewer	✅
3	STP Refiner	✅
4	STD Builder	✅
5	STD Reviewer	✅
6	STD Refiner	✅
7	Test Generator	✅

Test Output

Language	Count	Location
Go	1 files	`qf-tests/GH-11/go/`

Issue: GH-11

Generated by QualityFlow

guyoron1 · 2026-06-16T08:45:11Z

Closing — QF infrastructure updated on main, will re-create with improved pipeline.

fix(gcp): remove the project from the number call

98bb6d9

Add QualityFlow output for GH-11 [skip ci]

0451d58

fullsend-ai-review Bot suggested changes Jun 15, 2026

View reviewed changes

Add STP output for GH-11 [skip ci]

ff42f77

Add QualityFlow STP review for GH-11 [skip ci]

69a7705

Add QualityFlow output for GH-11 [skip ci]

9f8e63a

QualityFlow and others added 3 commits June 15, 2026 15:16

Add QualityFlow output for GH-11 [skip ci]

4526404

Add QualityFlow tests for GH-11

40e9ea7

Replaces intermediate pipeline artifacts with organized test files. Total: 1 test files → qf-tests/GH-11/ Jira: GH-11 [skip ci]

guyoron1 closed this Jun 16, 2026

guyoron1 deleted the fix/remove-quota-project branch June 16, 2026 08:45

Conversation

guyoron1 commented Jun 15, 2026

Uh oh!

guyoron1 commented Jun 15, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Review

Review

Findings

Critical

Low

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

QualityFlow Pipeline Summary

Test Output

Uh oh!

guyoron1 commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fullsend-ai-review Bot commented Jun 15, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 15, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 15, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 15, 2026 •

edited

Loading