Fix: surface the real booking error instead of generic 'Boeken mislukt'#6
Merged
Conversation
Tauri's invoke rejects with the Rust error STRING (e.g. the Simplicate API status + body), which isn't an Error instance — so the catch fell back to a generic "Boeken mislukt" and hid the actual reason a booking failed. Now string errors are shown as-is (and logged), with the generic message kept only for non-string, non-Error throws. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Booking from the leftover sidebar (and the timeline) showed a generic "Boeken mislukt" with no detail. The HTTP layer goes through Tauri
invoke, which rejects with the Rust error string (the Simplicate API status + body) — not anErrorinstance. The catch checkederr instanceof Error, so that real message was discarded and replaced by the generic fallback.Fix
Surface string errors as-is (and
console.errorthem); keep the generic message only for non-string, non-Error throws. Now a failed booking shows the actual Simplicate reason (e.g.Simplicate API error: 400 — ...), so the cause is visible instead of hidden.This is a diagnostic + UX fix — it doesn't change why a given booking fails, but it makes the reason visible so it can be acted on.
39 useBooking tests pass, typecheck clean.
🤖 Generated with Claude Code