Session 2 : adding dynamo db#2
Open
guillaumeduboc wants to merge 3 commits into
Open
Conversation
added 3 commits
October 20, 2021 17:38
Correcting GET route's response
guillaumeduboc
requested review from
thibaudlemaire
and removed request for
thibaudlemaire
guillaumeduboc
changed the title
|
|
||
| return success({ viruses }); | ||
| export const main: APIGatewayProxyHandler = async () => { | ||
| return documentClient.query({TableName: "dojo-serverless-table"}, function(err, data) { |
Collaborator
There was a problem hiding this comment.
Tu peux faire sans la callback, avec un async/await et un try/catch
| try { | ||
| await documentClient | ||
| .delete({ | ||
| TableName: 'dojo-serverless-table', |
Collaborator
There was a problem hiding this comment.
Tu peux mettre ça dans une constante
|
|
||
| const documentClient = new DynamoDB.DocumentClient(); | ||
|
|
||
| export const main: APIGatewayProxyHandler = async ({ pathParameters }) => { |
Collaborator
There was a problem hiding this comment.
Tu peux typer pathParameters
Comment on lines
76
to
92
| const addVirus = async () => { | ||
| console.log('Implement the post route first!'); | ||
| // const response = await fetch( | ||
| // `${process.env.REACT_APP_API_BASE_URL}/virus`, | ||
| // { method: 'POST' }, | ||
| // ); | ||
| // const { id } = await response.json(); | ||
| // setViruses((prevViruses) => prevViruses.concat(getRandomVirus(id))); | ||
| // console.log('Implement the post route first!'); | ||
| const response = await fetch( | ||
| `${process.env.REACT_APP_API_BASE_URL}/virus`, | ||
| { method: 'POST' }, | ||
| ); | ||
| const { id } = await response.json(); | ||
| setViruses((prevViruses) => prevViruses.concat(getRandomVirus(id))); | ||
| }; | ||
|
|
||
| const killVirus = async (virusId: string) => { | ||
| console.log('Implement the delete route first!'); | ||
| // await fetch(`${process.env.REACT_APP_API_BASE_URL}/virus/${virusId}`, { | ||
| // method: 'DELETE', | ||
| // }); | ||
| // setViruses((prevViruses) => prevViruses.filter(({ id }) => id !== virusId)); | ||
| // console.log('Implement the delete route first!'); | ||
| await fetch(`${process.env.REACT_APP_API_BASE_URL}/virus/${virusId}`, { | ||
| method: 'DELETE', | ||
| }); | ||
| setViruses((prevViruses) => prevViruses.filter(({ id }) => id !== virusId)); | ||
| }; |
Collaborator
There was a problem hiding this comment.
La bonne pratique c'est de sortir cette logique dans un service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.