Session 1 : Adding getVirus, createVirus and deleteVirus#1
Open
guillaumeduboc wants to merge 4 commits into
Open
Session 1 : Adding getVirus, createVirus and deleteVirus#1guillaumeduboc wants to merge 4 commits into
guillaumeduboc wants to merge 4 commits into
Conversation
guillaumeduboc
changed the title
|
|
||
| const listOfViruses: Array<Virus> = [{id: 1, type: 1},{id: 2, type: 1},{id: 3, type: 3},{id: 4, type: 2},{id: 5, type: 1}] | ||
|
|
||
| export const main: APIGatewayProxyHandler = async event => { |
Collaborator
There was a problem hiding this comment.
Tu peux déstructurer ton objet event pour plus de lisibilité :
export const main: APIGatewayProxyHandler = async { queryStringParameters } => {
| const listOfViruses: Array<Virus> = [{id: 1, type: 1},{id: 2, type: 1},{id: 3, type: 3},{id: 4, type: 2},{id: 5, type: 1}] | ||
|
|
||
| export const main: APIGatewayProxyHandler = async event => { | ||
| if (event.queryStringParameters != null && Object.keys(event.queryStringParameters).includes("id")){ |
Collaborator
There was a problem hiding this comment.
Du coup tu peux faire const {id} = queryStringParameters puis if (id !== null)
Comment on lines
+10
to
+17
| return { | ||
| statusCode: 200, | ||
| body: JSON.stringify({ | ||
| message: targettedVirus, | ||
| input: event, | ||
| }), | ||
| }; | ||
| } else { |
Collaborator
There was a problem hiding this comment.
Tu peux éviter la duplication en écrivant un générateur de réponse HTTP
Comment on lines
+7
to
+9
| headers: { | ||
| 'Access-Control-Allow-Origin': '*', | ||
| }, |
Collaborator
There was a problem hiding this comment.
Tu peux déléguer ça à API Gateway : https://docs.aws.amazon.com/fr_fr/apigateway/latest/developerguide/how-to-cors.html
| id: string; | ||
| positionX: number; | ||
| positionY: number; | ||
| virus_category: number; |
Collaborator
There was a problem hiding this comment.
Prends l'habitude d'utiliser du camelCase : https://fr.wikipedia.org/wiki/Camel_case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.