Skip to content

Aimalign!#23

Open
eerinn wants to merge 22 commits into
mainfrom
aimalign!
Open

Aimalign!#23
eerinn wants to merge 22 commits into
mainfrom
aimalign!

Conversation

@eerinn

@eerinn eerinn commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

eerinn and others added 22 commits February 23, 2026 18:22
This reverts commit 9435410.
…gic, added ability to limit flywheel speed for testing
Resolved merge conflict in AlignUtil.java by accepting incoming changes from aim! branch.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
swerve uses motion magic + driver keybinds
- Fixed shooter position calculation by properly rotating offset by robot heading
- Removed incorrect Transform2d rotation that was affecting target angle
- Converted static methods to instance methods to prevent null reference issues
- Updated RobotContainer to use new createAimCommand() method
- Added resetToStartingPosition() method to SwerveSubsystem for testing
- Bound Options button to reset pose to red hub neutral zone (10.4, 4.0)
- Fixed deprecated getPositionError() call in RotateToAngleCommand
- Added options() button accessor to PS5DriveController

NEED TO DO: Fix pigion heading issue
…dont need a negitive pid, also offset turn by 90* because we dont want to allign to front rather want to do right side, also fixed the keybind issue where it counted the trigger r2 being pressed as a cancel

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18: shootoffset should probably be in shooter constants

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier comment extends to this, Cancelcondition not implemented to beware

@EthanCui2008

Copy link
Copy Markdown

this should [probably] be merged into premergeofdoom

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment at some point

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, implement Cancelcondition at some point

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you guys don't want to reset the hood angle periodically? That or this is clubbing a feature

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printlns + shouldn't this be a singleton?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alot of formatting changes assumedely as per GRT conventions.
Reminding myself to take a second look but why is acceleration limiting being implemented now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants