Skip to content

Denorms the 1st checkout date to the asset table#18511

Open
Godmartinz wants to merge 10 commits into
grokability:developfrom
Godmartinz:denorm_1st_checkout_migration
Open

Denorms the 1st checkout date to the asset table#18511
Godmartinz wants to merge 10 commits into
grokability:developfrom
Godmartinz:denorm_1st_checkout_migration

Conversation

@Godmartinz

Copy link
Copy Markdown
Member

This removes the addSelect from the asset index and denormalizes the field to the assets table with a DB update in a migration.

another migration is created before the backfill of the first_checkout_at date, to index the action_log by [item_type, item_id, action_type, created_at] to make the whole matching process quicker.

@Godmartinz Godmartinz requested a review from snipe as a code owner February 5, 2026 00:42
@Godmartinz Godmartinz marked this pull request as draft February 5, 2026 00:43
@Godmartinz Godmartinz marked this pull request as ready for review February 5, 2026 17:57
@snipe snipe requested a review from uberbrady February 6, 2026 10:50
@snipe

snipe commented Feb 7, 2026

Copy link
Copy Markdown
Member

@uberbrady Please look at this one carefully when you get a moment. Folks with a lot of action logs could run into issues here.

@uberbrady uberbrady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a swing at this! I think it's a good start, but I'd like to see a few things change, if we can. Let's hop together on the pairing channel to see if we can get this across the finish line. Some very sophisticated query logic in here; I'm impressed :)

Comment thread app/Http/Controllers/Assets/AssetCheckoutController.php
@Godmartinz Godmartinz requested a review from uberbrady February 19, 2026 00:35
# Conflicts:
#	app/Http/Controllers/Assets/AssetCheckoutController.php
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity

Metric Results
Complexity 5

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants