Remove AcceptOrgUserByOrgId from AcceptOrgUserCommand to simplify interface#62
Open
lizard-boy wants to merge 2 commits into
Open
Remove AcceptOrgUserByOrgId from AcceptOrgUserCommand to simplify interface#62lizard-boy wants to merge 2 commits into
lizard-boy wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
LGTM
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
In researching a bug, I identified that there was the potential to remove one of the methods by which we accept a user into an org. We could simplify the interface and also avoid re-retrieving the
OrganizationUserwhen we already have it in the calling method.Code changes
Before you submit
dotnet format --verify-no-changes) (required)Greptile Summary
This pull request removes the
AcceptOrgUserByOrgIdmethod from theAcceptOrgUserCommandinterface and updates related classes to simplify the codebase and avoid redundant data retrieval.AcceptOrgUserByOrgIdAsyncmethod fromsrc/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/Interfaces/IAcceptOrgUserCommand.cssrc/Api/AdminConsole/Controllers/OrganizationUsersController.csto useAcceptOrgUserAsyncwithorgUserobject directlytest/Api.Test/AdminConsole/Controllers/OrganizationUsersControllerTests.csto reflect new method signaturetest/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/AcceptOrgUserCommandTests.cs