[BRE-101] Remove dept-devops from CODEOWNERS#56
Open
lizard-boy wants to merge 3 commits into
Open
Conversation
…rtnership Phase 2
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+7
to
+11
| ## Docker files have shared ownership ## | ||
| **/Dockerfile | ||
| **/*.Dockerfile | ||
| **/.dockerignore | ||
| **/entrypoint.sh |
There was a problem hiding this comment.
logic: Docker files now have shared ownership, but no specific team is assigned. This could lead to unclear responsibility for these critical files.
Comment on lines
+16
to
+22
| ## These are shared workflows ## | ||
| .github/workflows/_move_finalization_db_scripts.yml | ||
| .github/workflows/build.yml | ||
| .github/workflows/cleanup-after-pr.yml | ||
| .github/workflows/cleanup-rc-branch.yml | ||
| .github/workflows/release.yml | ||
| .github/workflows/repository-management.yml |
There was a problem hiding this comment.
logic: These workflows are listed as shared, but no specific owners are assigned. This may lead to a lack of clear responsibility for maintaining these important files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-101
📔 Objective
Remove dept-devops from CODEOWNERS. Add
dept-breas owner of.github/workflows/release.yml📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request modifies the CODEOWNERS file to restructure ownership responsibilities, particularly for the release workflow. Here are the key changes:
dept-devopsfrom general ownership of.github/workflowsdept-breas the owner of.github/workflows/release.ymldept-devopsanddept-brerelease.yml, owned bydept-breThese changes aim to align the ownership structure with team responsibilities, potentially impacting how the release process is managed and who is responsible for reviewing changes to critical workflows.