Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .claude/commands/gen-test.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
description: Generate tests for a target (module/function/file) following this repo's conventions, then run them
argument-hint: <target> — e.g. spin2note_api.clickhouse.queries, apps/api/src/.../worker.py, or crates/hh-parser
allowed-tools: Read, Edit, Write, Bash(cd*), Bash(uv*), Bash(cargo*), Bash(. *)
---

Generate tests for **$ARGUMENTS** that match how this project already writes tests, then run
them and confirm they pass. Do not invent a new style — mirror the existing tests.

## 1. Read the target and a sibling test
- Read the target code (`$ARGUMENTS`) and identify the behaviours worth covering: happy path,
edge cases, error paths, and any invariant the code protects (e.g. "never single-row insert",
"dedup skips existing", "Rust hand_id == Python").
- Read the closest existing test to copy its conventions. Map of patterns:
- **`tests/test_batcher.py`** — pure async unit test with an injected spy `insert_fn`; asserts
block sizes / no-loss. Use for batcher/queue/pure-logic code.
- **`tests/test_worker.py`** — stubs `FakeCH` (async `query` returning canned `result_rows`)
and a `CollectBatcher` subclass; `pytest.importorskip("hh_parser")` then `# noqa: E402`
imports; fixtures read from `TESTDATA = parents[3]/"testdata"`. Use for worker/parser-backed.
- **`tests/test_api.py`** — FastAPI `TestClient` + `app.dependency_overrides` for `require_user`
/ `get_api_client`, and `monkeypatch.setattr(queries, ...)`. Use for HTTP routes.
- **`tests/test_native.py`** / **`tests/test_queries.py`** — fake ClickHouse conn/client that
counts calls; assert serialization / batching invariants. Use for clickhouse layer.

## 2. Write the test
- **Python:** create/extend `apps/api/tests/test_<area>.py`. Rules: `from __future__ import
annotations`; `asyncio_mode=auto` (async tests are plain `async def test_...`, no decorator);
if it imports the compiled parser, add `pytest.importorskip("hh_parser")` before those imports;
never hit real ClickHouse/Postgres/Redis/MinIO — stub them (reuse `FakeCH`/`CollectBatcher`
patterns); read sample data from `testdata/` not the gitignored `testdata/real/`. Keep line
length ≤100 (ruff).
- **Rust:** add an inline `#[cfg(test)] mod tests { ... }` block in the relevant
`crates/hh-parser/src/*.rs` (see `parser.rs`/`summary.rs`), with `const` fixtures inline.
- **Frontend:** no test setup exists yet — if asked, propose adding Vitest first, don't fake it.

## 3. Run and confirm (must pass before finishing)
```bash
cd apps/api && uv run ruff check . && uv run mypy src && uv run pytest -q # Python
cargo test --manifest-path crates/hh-parser/Cargo.toml # Rust (from repo root)
```
If a Python test needs the parser, build it once: `uv run maturin develop --manifest-path
../../crates/hh-parser/Cargo.toml`. Report which cases were added and the passing result. Never
weaken an assertion to make it pass — fix the test or surface the real bug.
34 changes: 34 additions & 0 deletions apps/api/tests/test_migrate.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
"""SQL statement splitting for the ClickHouse migration runner.

Regression for the bug where a ';' inside a `--` comment split a statement and comment-only
chunks were sent to ClickHouse as empty queries.
"""

from __future__ import annotations

from spin2note_api.clickhouse.migrate import _statements


def test_splits_plain_statements() -> None:
assert _statements("CREATE TABLE a (x Int8); CREATE TABLE b (y Int8)") == [
"CREATE TABLE a (x Int8)",
"CREATE TABLE b (y Int8)",
]


def test_strips_line_comments_and_ignores_semicolons_inside_them() -> None:
sql = """
-- statements are separated by ';' (this ; must NOT split anything)
CREATE TABLE a (x Int8);
-- a standalone comment line
CREATE TABLE b (y Int8);
"""
assert _statements(sql) == ["CREATE TABLE a (x Int8)", "CREATE TABLE b (y Int8)"]


def test_comment_only_input_yields_no_statements() -> None:
assert _statements("-- just a comment\n-- another;one\n") == []


def test_trailing_semicolon_and_blank_lines_are_dropped() -> None:
assert _statements("TRUNCATE TABLE t;\n\n \n") == ["TRUNCATE TABLE t"]
Loading