Repository navigation
Make /server-down kill steps reliable - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
/server-downso it reliably stops the API in one shot.The previous
pkill -f "…" || truesteps — especially when chained on one line — kept abortingafter the first command (exit 144), leaving the uvicorn API alive on :8000 and requiring a manual
PID kill.
Changes
pgrep -f "…" | xargs -r kill 2>/dev/null; true— kills by PIDdeterministically, won't match the wrong process or get interrupted.
allowed-toolsaccordingly (pgrep,kill,xargs).Docs/tooling only — no application code changes.