You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@greenrobot@greenrobot-team can this fix be looked at merging? Anyone that's doing chained joins has to be casting the sourceJoin argument here to the incorrect Join<?, T> in order for the method to accept the argument. Your own chained join sample won't compile with the code as is.
Part of the problem is that the return type of the method actually isn't Join<T, J>, but rather Join<J, K>, as the QueryBuilder's T is not the intended type of the chained join, rather it's joining to a new K type, from the J type of the previous join. The method signature would be more appropriate as:
I created a pull request with the fix I described above: #913.
This pull request fix will work, but the type of the Join generics are still incorrect, which although they're not actually used, can be misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.