perf(logging): default file log level to info#14
Merged
Conversation
The previous default file filter was `oxide_gnss=debug,ntrip_core=info,info`, which caused every per-epoch `debug!()` event to be emitted to the file appender. This wasunnecessary. Default file filter is now `info`. Set `OXIDE_GNSS_FILE_LOG=oxide_gnss=debug` to restore the previous behavior when actively debugging. `RUST_LOG` continues to control stderr filtering separately and is unchanged.
Note the file log filter default change under [Unreleased].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxide_gnss=debug,ntrip_core=info,infotoinfoglobally. Per-epochdebug!()events on the device, ROS, and NTRIP hot paths are no longer written to the file appender by default.OXIDE_GNSS_FILE_LOG=oxide_gnss=debugrestores the previous behavior when actively debugging.RUST_LOGcontinues to control stderr independently and is unchanged.docs/PROFILING.mdfor the profiling investigation that motivated this. Impact on oxide_gnss has not been measured in this repo.