Add/get scan report command#3043
Merged
Merged
Conversation
Introduce a structured model for loading a single vulnerability report. This adds: report metadata task and target information resource and result summaries filter and usage-type validation timezone handling memory cleanup Audit reports remain separate.
Add GMP handling and XML output for structured report retrieval. Include report metadata, task, target, progress, resource counts, result counts, severity, and scan information.
Add GMP documentation for structured report retrieval, including request attributes, response fields, filtering, and an example.
greenbonebot
enabled auto-merge (rebase)
July 17, 2026 13:17
* rename related functions and files * align the command name with the scan report resource * add support for singular GET response wrappers * generate matching get_scan_report_response start and end tags
a-h-abdelsalam
approved these changes
Jul 21, 2026
|
|
||
| if (find_attribute (attribute_names, | ||
| attribute_values, | ||
| "report_id", |
Member
There was a problem hiding this comment.
Wouldn't it make sense to name the attribute scan_report_id for consistency?
Comment on lines
+550
to
+552
| get_data_set_extra (&get_scan_report_data.get, | ||
| "report_id", | ||
| attribute); |
Member
There was a problem hiding this comment.
Is this really needed? For me this only makes sense for getting objects inside the report like get_report_hosts.
| && strcasecmp (type, "report_tls_certificate") | ||
| && strcasecmp (type, "report_vuln"); | ||
| && strcasecmp (type, "report_vuln") | ||
| && strcasecmp (type, "scan_report"); |
Member
There was a problem hiding this comment.
The reports do have owners, so this should not be in here even though it may require some changes to ensure the permission checks use the "subtype".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_scan_reportcommandWhy
References
GEA-1937