Skip to content

Add/agents support bundle#1083

Merged
greenbonebot merged 4 commits into
mainfrom
add/agents-support-bundle
Jun 17, 2026
Merged

Add/agents support bundle#1083
greenbonebot merged 4 commits into
mainfrom
add/agents-support-bundle

Conversation

@ozgen

@ozgen ozgen commented Jun 17, 2026

Copy link
Copy Markdown
Member

What

  • Preserve binary HTTP response data without relying on string length.
  • Store the exact response size in gvm_http_response_t.
  • Capture the Content-Disposition response header.
  • Add support for downloading an agent support bundle.
  • Extract and return the support bundle filename.
  • Add unit tests for binary data, filename parsing, request construction, and error cases.

Why

  • Support bundles contain binary data and may include null bytes.
  • Using string-based handling can truncate or corrupt binary responses.
  • The filename is provided through the Content-Disposition header and is needed when saving the downloaded bundle.
  • Tests ensure binary content, metadata, and failure cases are handled correctly.

References

GEA-1833

Checklist

  • Tests

ozgen added 4 commits June 15, 2026 11:00
Add support bundle download support for agents.

Capture the Content-Disposition response header, extract the returned
filename, and preserve binary response data and size in the support bundle
object.
@ozgen ozgen requested review from a team as code owners June 17, 2026 07:33
@greenbonebot greenbonebot enabled auto-merge (rebase) June 17, 2026 07:33
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 76d4235.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot greenbonebot merged commit f3b98b1 into main Jun 17, 2026
24 checks passed
@greenbonebot greenbonebot deleted the add/agents-support-bundle branch June 17, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants