Skip to content

fix: Improve curl TLS certificate error logging #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenbonebot merged 1 commit into from
Jun 5, 2026
Merged

fix: Improve curl TLS certificate error logging #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions http/httputils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ gvm_http_new_internal (const gchar *url, gvm_http_method_t method,
gvm_http_response_stream_t res)
{
CURL *curl = curl_easy_init ();
CURLcode ret = CURLE_OK;

if (!curl)
return NULL;

Expand Down Expand Up @@ -151,9 +153,11 @@ gvm_http_new_internal (const gchar *url, gvm_http_method_t method,
CURL_BLOB_COPY};
curl_easy_setopt (curl, CURLOPT_SSL_VERIFYPEER, 1L);
curl_easy_setopt (curl, CURLOPT_SSL_VERIFYHOST, 1L);
if (curl_easy_setopt (curl, CURLOPT_CAINFO_BLOB, &ca_blob) != CURLE_OK)
ret = curl_easy_setopt (curl, CURLOPT_CAINFO_BLOB, &ca_blob);
if (ret != CURLE_OK)
{
g_warning ("%s: Failed to set CA certificate", __func__);
g_warning ("%s: Failed to set CA certificate: %s", __func__,
curl_easy_strerror (ret));
curl_easy_cleanup (curl);
return NULL;
}
Expand All @@ -174,17 +178,21 @@ gvm_http_new_internal (const gchar *url, gvm_http_method_t method,
CURL_BLOB_COPY};
struct curl_blob key_blob = {(void *) client_key, strlen (client_key),
CURL_BLOB_COPY};

if (curl_easy_setopt (curl, CURLOPT_SSLCERT_BLOB, &cert_blob) != CURLE_OK)
ret = curl_easy_setopt (curl, CURLOPT_SSLCERT_BLOB, &cert_blob);
if (ret != CURLE_OK)
{
g_warning ("%s: Failed to set client certificate", __func__);
g_warning ("%s: Failed to set client certificate: %s", __func__,
curl_easy_strerror (ret));
curl_easy_cleanup (curl);
return NULL;
}

if (curl_easy_setopt (curl, CURLOPT_SSLKEY_BLOB, &key_blob) != CURLE_OK)
ret = curl_easy_setopt (curl, CURLOPT_SSLKEY_BLOB, &key_blob);

if (ret != CURLE_OK)
{
g_warning ("%s: Failed to set client private key", __func__);
g_warning ("%s: Failed to set client private key: %s", __func__,
curl_easy_strerror (ret));
curl_easy_cleanup (curl);
return NULL;
}
Expand Down
Loading