Skip to content

Add/agent controller installer instructions#1076

Merged
greenbonebot merged 3 commits into
mainfrom
add/agent-controller-installer-instructions
Jun 2, 2026
Merged

Add/agent controller installer instructions#1076
greenbonebot merged 3 commits into
mainfrom
add/agent-controller-installer-instructions

Conversation

@ozgen

@ozgen ozgen commented Jun 1, 2026

Copy link
Copy Markdown
Member

What

  • Added support for getting installer instructions from the Agent Controller.
  • Added language support for the installer instruction request.
  • Added custom headers for this request.
  • Fixed URL setup error handling.
  • Added unit tests.

Why

  • We need to request installer instructions in the selected language.
  • The request needs an Accept: application/json header.
  • The URL helper should fail safely when the URL cannot be built.
  • Tests were added to cover the new behavior.

References

GEA-1809

Checklist

  • Tests

ozgen added 2 commits June 1, 2026 16:13
The installer instruction request now sends Accept: application/json and resolves the language parameter from instructions_lang_type_t.

Also fix the URL helper return type so request setup failures are handled safely.
@ozgen ozgen requested review from a team as code owners June 1, 2026 14:15
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 6ef2e69.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot greenbonebot enabled auto-merge (rebase) June 1, 2026 14:16
robindittmar
robindittmar previously approved these changes Jun 2, 2026
Comment thread agent_controller/agent_controller.c Outdated
Comment thread agent_controller/agent_controller.c Outdated
@greenbonebot greenbonebot merged commit 549675b into main Jun 2, 2026
19 checks passed
@greenbonebot greenbonebot deleted the add/agent-controller-installer-instructions branch June 2, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants