Skip to content

Add scan-config-json type#357

Open
soumya-greenbone wants to merge 2 commits into
mainfrom
DEVOPS-2126-add-type-scan-configs-json
Open

Add scan-config-json type#357
soumya-greenbone wants to merge 2 commits into
mainfrom
DEVOPS-2126-add-type-scan-configs-json

Conversation

@soumya-greenbone

Copy link
Copy Markdown

What

Add a dedicated scan-config-json / scan-config-jsons feed sync type and related URL/destination settings.

Why

OPENVAS DETECT/OEM customers need scan configs as JSON, but these files should be synced only when explicitly requested.

References

DEVOPS-2126

Checklist

  • Tests
    validated with parser/config unit tests, running Ruff and black.

@soumya-greenbone soumya-greenbone requested review from a team as code owners June 23, 2026 13:16
@greenbonebot greenbonebot enabled auto-merge (rebase) June 23, 2026 13:16
@github-actions

Copy link
Copy Markdown

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.36%. Comparing base (edefe72) to head (7decabc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files           7        7           
  Lines         470      472    +2     
=======================================
+ Hits          467      469    +2     
  Misses          3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soumya-greenbone soumya-greenbone force-pushed the DEVOPS-2126-add-type-scan-configs-json branch from 215d11f to ab0da39 Compare June 23, 2026 13:33

@bjoernricks bjoernricks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an enterprise only feature as the jsons are not available for the community, I just want to be sure that this command is optional and not run when calling greenbone-feed-sync without arguments?

@soumya-greenbone

Copy link
Copy Markdown
Author

As this is an enterprise only feature as the jsons are not available for the community, I just want to be sure that this command is optional and not run when calling greenbone-feed-sync without arguments?

Yes, that is the intention. The new scan-config-json / scan-config-jsons type is optional only.
It is not included in the all type, so running greenbone-feed-sync without arguments will not try to sync the JSON scan configs. It will only run when explicitly called with --type scan-config-json or --type scan-config-jsons.

https://github.com/greenbone/greenbone-feed-sync/pull/357/changes#diff-5f1bb248c0aeaf0116f9f2e0b9c824180e98f5107cb03f4d19edcf4d030296ddR162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants