fix(home): refine search pill — smaller, single view icon, distinct icons, sort text fix#78
Merged
Merged
Conversation
- Shorter pill: height 40px->36px, input 32px; narrower (margins 215/314). - View toggle shows ONE icon at a time: hide the active .view-btn on desktop so only the target-view icon shows; clicking it switches the view and the icon swaps to the other (grid <-> list). - System Type icon changed from the 2x2 grid (clashed with grid-view icon) to a distinct 'layers' icon. - Sort icon no longer injects an 'A-Z'/'Z-A' bare text node when toggled: the JS now writes the direction into the .filter-label span (hidden on desktop, shown on mobile) instead of childNodes[last] (a whitespace node after the span), which had been rendering visible text and stretching the button. Icon stays the default arrows glyph (flips for direction). Verified via Interceptor (real built site, both themes): pill 36x623; one view icon visible; toggle swaps icon + view; System Type icon = layers; sort click injects no bare text; dropdowns still open; header height 64px.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four refinements to the Google-style header search pill (#77):
40px → 36px(input32px), and a little narrower (reserve margins185/284 → 215/314)..view-btnon desktop so only the target-view icon shows; clicking it switches the view and the icon swaps (grid ⇄ list). CSS-only; mobile keeps its segmented toggle.childNodes[last], which (after the label was wrapped in a span) is the trailing whitespace text node → it rendered a visible bare "A-Z" and stretched the button. Now it writes into the.filter-labelspan (hidden on desktop, correct on mobile). The icon stays the default arrows glyph.Verification (Interceptor, real built site, both themes)
icon_swapped: true, view_changed: true).polygon+polyline+polyline), no longer grid rects..filter-label.Build verified (exit 0). Files:
style.css+index.html.