Implement structurally shared validator list#763
Open
ArtiomTr wants to merge 2 commits into
Open
Conversation
ArtiomTr
force-pushed
the
feature/structurally-shared-validator-list
branch
from
994045f to
6159588
Compare
This commit employs Structure of Arrays (SoA) pattern for implementing validator list container. The validator fields are split into three lists - pubkeys, effective balances, and rest of fields. Because pubkey list is strictly append-only, such validator list structure saves memory when loading historical state from disk - instead of copying every public key from finalized state into a newly loaded one, we can attach whole pubkey list at once, re-using memory for all keys.
ArtiomTr
force-pushed
the
feature/structurally-shared-validator-list
branch
from
6159588 to
7b02b50
Compare
This change moves index_of_pubkey cache to the PubkeyList container. It allows to re-use index cache when restoring validator keys to state loaded from disk, reducing memory usage and increasing performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR employs Structure of Arrays (SoA) pattern for implementing validator list container. The validator fields are split into three lists - pubkeys, effective balances, and rest of fields. Because pubkey list is strictly append-only, such validator list structure saves memory when loading historical state from disk - instead of copying every public key from finalized state into a newly loaded one, we can attach whole pubkey list at once, re-using memory for all keys.