Conversation
newFileConsole opened the --console-output file with os.OpenFile, which broke tests that use an in-memory FS. Open the file via fsext instead. Fixes grafana#2565
aamoghS
requested review from
AgnesToulet and
janHildebrandt98
and removed request for
a team
September 19, 2026 13:18
Signed commits report1 of 1 commit between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write
--console-outputthrough the filesystem abstraction instead ofos.OpenFile, so tests that use an in-memory FS work.Fixes #2565
Test plan
go test ./internal/js/ -count=1 -run Consolek6 run --console-output=out.logwrites console.log to that file