build: make release-check reproducible (lock build/twine, fix packaging conflict) - #63
Merged
Merged
Conversation
…heck make release-check imperatively ran uv pip install --upgrade build twine, but the subsequent uv run re-synced the environment to the lockfile, reverting packaging to the locked 26.0 while twine 7 requires >=26.1. That broke both local release-check and the tag-triggered publish CI job with "ImportError: cannot import name 'errors' from 'packaging'". Add a locked release dependency group (build, twine) and switch release-check to uv sync --group release, so the build/validate step is reproducible and packaging resolves coherently (now 26.3). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dinbinn
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tag-triggered
publishCI job (and localmake release-check) fail at the twine step with:Root cause:
release-checkranuv pip install --upgrade build twineimperatively (pulling twine 7, which requirespackaging>=26.1), but the subsequentuv runre-synced the environment touv.lock, which pinnedpackaging==26.0. twine 7 then failed to importpackaging.errors.This blocks the automated release: the
publishjob builds from the tagged commit, so pushingv0.0.6as-is would fail CI, skipping the PyPI upload and the GitHub Release (releasejobneeds: publish).Fix
releasedependency group (build,twine) topyproject.toml.make release-checkfrom the imperativeuv pip install --upgrade build twinetouv sync --group release.uv.locknow carriesbuild,twine 7.0.0, and a coherentpackaging 26.3.Now the build/validate step is reproducible and no longer depends on an imperative upgrade racing the lockfile.
Verification
make release-checkpasses end-to-end locally (build +twine check):🤖 Generated with Claude Code