[TEST] 운임 계산 서비스 테스트#232
Merged
Merged
Conversation
Yunsung-Jo
requested review from
EndlessMilkyway,
Friox,
Jimin730,
Ogu1208 and
chanwonlee
chanwonlee
approved these changes
Aug 6, 2025
chanwonlee
left a comment
chanwonlee
left a comment
Contributor
There was a problem hiding this comment.
테스트 확인했습니다! @ParameterizedTest를 이렇게 사용하는 방식은 처음보는데 덕분에 새로운 활용법을 배워갑니다! 고생하셨습니다!
Jimin730
approved these changes
Aug 7, 2025
Jimin730
left a comment
Jimin730
left a comment
Contributor
There was a problem hiding this comment.
확인했습니다 👍
@ParameterizedTest 와 @MethodSource 는 한 번도 사용을 안해봤는데 사용법을 한 번 볼 수 있어서 좋았습니다 ! 고생하셨습니다 👍 👍
EndlessMilkyway
approved these changes
Aug 7, 2025
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
Contributor
There was a problem hiding this comment.
@ParameterizedTest와 @MethodSource를 통한 메서드 재사용이 인상깊은 테스트 코드였습니다. 고생하셨습니다!
Friox
approved these changes
Aug 7, 2025
Friox
left a comment
Friox
left a comment
Contributor
There was a problem hiding this comment.
테스트 특성에 맞게 ParameterizedTest 어노테이션을 잘 사용하신 것 같습니다!
고생하셨습니다~ 👍👍
Ogu1208
approved these changes
Aug 7, 2025
Ogu1208
left a comment
Ogu1208
left a comment
Contributor
There was a problem hiding this comment.
@ParameterizedTest 사용해서 잘 작성해주신 것 같습니다!
고생하셨습니다~ 👍
Yunsung-Jo
force-pushed
the
test/216-fare-calculation-service
branch
from
6ae1bb0 to
046446d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
리뷰어 참고 사항
없음
추가 정보
없음
PR 작성 체크리스트 (필수)