[TEST] Member 서비스 테스트 코드 작성 #230
Merged
Merged
Conversation
Jimin730
requested review from
EndlessMilkyway,
Ogu1208,
Yunsung-Jo,
chanwonlee and
friox
August 6, 2025 14:40
chanwonlee
approved these changes
Aug 6, 2025
chanwonlee
left a comment
chanwonlee
left a comment
Contributor
There was a problem hiding this comment.
member 서비스 테스트 코드 확인했습니다! 저는 그동안 Exception을 검증할때 assertThatThrownBy을 주로 사용했는데 assertThatExceptionOfType으로도 검증할 수 있다는 걸 알게된 것 같습니다. 고생하셨습니다!
friox
approved these changes
Aug 7, 2025
friox
left a comment
friox
left a comment
Contributor
There was a problem hiding this comment.
테스트를 위해 레포지토리 메서드도 추가하셨네요,
고생하셨습니다! 👍👍
EndlessMilkyway
approved these changes
Aug 7, 2025
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
Contributor
There was a problem hiding this comment.
성공하는 경우와 실패하는 경우 등 모든 케이스에 대해 테스트 코드를 잘 작성하신 것 같습니다.
고생하셨습니다! 👍
Jimin730
force-pushed
the
test/205-member-service
branch
from
August 7, 2025 01:38
d08e6f8 to
4e8a654
Compare
Ogu1208
approved these changes
Aug 7, 2025
Ogu1208
left a comment
Ogu1208
left a comment
Contributor
There was a problem hiding this comment.
저도 이번에 @SQLRestriction 를 붙일때 쿼리 조건이 매번 붙어서 나가고 이런 유형들의 어노테이션이 있는지 처음 알게된 것 같습니다! 항상 잘 알아보고 써야겠다고 다시 한번 생각이 드네요ㅜㅜ
고생하셨습니다 👍
Jimin730
force-pushed
the
test/205-member-service
branch
from
August 7, 2025 01:41
4e8a654 to
2da612f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
MemberRepository에 soft delete 조건 우회하는 네이티브 쿼리 추가리뷰어 참고 사항
없음
추가 정보
없음
PR 작성 체크리스트 (필수)