[TEST] 이메일 인증 관련 테스트 코드 작성#228
Merged
Merged
Conversation
Jimin730
requested review from
EndlessMilkyway,
Ogu1208,
Yunsung-Jo,
chanwonlee and
friox
August 6, 2025 14:09
chanwonlee
approved these changes
Aug 6, 2025
chanwonlee
left a comment
chanwonlee
left a comment
Contributor
There was a problem hiding this comment.
이메일 인증 관련 테스트 코드 확인했습니다! 메일 테스트를 위한 GreenMail도 덕분에 알게 되었습니다. 고생하셨습니다!
EndlessMilkyway
approved these changes
Aug 7, 2025
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
Contributor
There was a problem hiding this comment.
지민님이 작성해주신 테스트 코드를 리뷰하며 GreenMail 라이브러리를 사용할 경우 메일 서비스에 대한 테스트를 진행할 수 있다는 것을 알게되었습니다. 고생하셨습니다!
friox
approved these changes
Aug 7, 2025
friox
left a comment
friox
left a comment
Contributor
There was a problem hiding this comment.
이메일 서버에 대한 테스트 환경을 별도로 구축하여 진행할 수 있네요,
테스트 관련하여 많이 배워갑니다! 고생하셨습니다~ 👍👍
Ogu1208
approved these changes
Aug 7, 2025
Ogu1208
left a comment
Ogu1208
left a comment
Contributor
There was a problem hiding this comment.
정말 꼼꼼하게 있을 수 있는 모든 시나리오에 대해서 테스트를 작성해주신 것 같습니다!
GreenMail도 처음 보네요. 테스트용 메일 서버라니 없는 라이브러리가 없군요..!
고생하셨습니다~ 👍
Jimin730
force-pushed
the
test/219-email-service-test
branch
from
August 7, 2025 01:34
bd08279 to
d871158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
MockMailConfig제거RailoApplicationTests에 MockMailConfig@Import어노테이션 제거EmailAuthService테스트 코드 작성MemberFindService테스트 코드 작성MemberUpdateService테스트 코드 작성리뷰어 참고 사항
없음
추가 정보
없음
PR 작성 체크리스트 (필수)