[TEST] AuthService 테스트 코드 작성#222
Merged
Merged
Conversation
Jimin730
requested review from
EndlessMilkyway,
Ogu1208,
Yunsung-Jo,
chanwonlee and
friox
August 6, 2025 05:06
EndlessMilkyway
approved these changes
Aug 6, 2025
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
Contributor
There was a problem hiding this comment.
확인 완료했습니다. 고생 많으셨습니다!
friox
approved these changes
Aug 7, 2025
friox
left a comment
friox
left a comment
Contributor
There was a problem hiding this comment.
일어날 수 있는 케이스를 잘 잡으셨고 given-when-then 패턴도 일관적으로 잘 사용하셨네요,
고생하셨습니다! 👍👍
Ogu1208
approved these changes
Aug 7, 2025
Ogu1208
left a comment
Ogu1208
left a comment
Contributor
There was a problem hiding this comment.
확실히 테스트 코드로 시나리오를 보니 문서로서의 역할로 더 이해가 잘 되는 것 같습니다!
고생하셨습니다~ 👍
Jimin730
force-pushed
the
test/218-auth-service-test
branch
from
August 7, 2025 01:25
702c4a7 to
33fb9ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
회원가입테스트 코드 작성로그인테스트 코드 작성로그아웃테스트 코드 작성토큰 재발급테스트 코드 작성application-test.yml파일 수정리뷰어 참고 사항
application-test.yml 파일에 임시로 설정해 둔 jwt secret key 길이가 짧아
토큰 부분 테스트 시 오류가 발생 하여 임시 key 의 길이를 더 길게 조정하였습니다 !
추가 정보
없음
PR 작성 체크리스트 (필수)