gooneyryan/hermes-webui
1
0
Fork 0
mirror of https://github.com/nesquena/hermes-webui.git synced 2026-05-25 11:10:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sessions): sync URL after session id rotation (#1395)

Browse Source
This commit is contained in:
Hermes Bot
2026-05-02 17:41:05 +00:00
parent 5650d1107a 9e894a2555
commit f0ed4aaa59
2 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/messages.js
+8
View File
@@ -836,6 +836,10 @@ function attachLiveStream(activeSid, streamId, uploaded=[], options={}){
const _prevOut=(S.session&&S.session.output_tokens)||0;
const _prevCost=(S.session&&S.session.estimated_cost)||0;
S.session=d.session;S.messages=d.session.messages||[];if(typeof _messagesTruncated!=='undefined')_messagesTruncated=!!d.session._messages_truncated;
if(S.session&&S.session.session_id){
localStorage.setItem('hermes-webui-session',S.session.session_id);
if(typeof _setActiveSessionUrl==='function') _setActiveSessionUrl(S.session.session_id);
}
if(
window._compressionUi&&window._compressionUi.automatic&&
window._compressionUi.sessionId===activeSid&&
@@ -1101,6 +1105,10 @@ function attachLiveStream(activeSid, streamId, uploaded=[], options={}){
S.activeStreamId=null;
clearLiveToolCards();if(!assistantText)removeThinking();
S.session=session;S.messages=(session.messages||[]).filter(m=>m&&m.role);
if(S.session&&S.session.session_id){
localStorage.setItem('hermes-webui-session',S.session.session_id);
if(typeof _setActiveSessionUrl==='function') _setActiveSessionUrl(S.session.session_id);
}
const hasMessageToolMetadata=S.messages.some(m=>{
if(!m||m.role!=='assistant') return false;
// Recognize both the standard `tool_calls` (used by completed assistant
tests/test_session_rotate_url_sync.py
+24
View File
@@ -0,0 +1,24 @@
"""Regression tests for session id rotation URL sync."""
from pathlib import Path
REPO_ROOT = Path(__file__).parent.parent.resolve()
MESSAGES_JS = (REPO_ROOT / "static" / "messages.js").read_text(encoding="utf-8")
def test_stream_completion_syncs_rotated_session_id_to_tab_state():
"""When compact/restore returns a new session id, the tab anchor follows it."""
completion_marker = "S.session=d.session;S.messages=d.session.messages||[]"
settled_marker = "S.session=session;S.messages=(session.messages||[]).filter(m=>m&&m.role);"
completion_pos = MESSAGES_JS.find(completion_marker)
settled_pos = MESSAGES_JS.find(settled_marker)
assert completion_pos != -1
assert settled_pos != -1
completion_block = MESSAGES_JS[completion_pos : completion_pos + 500]
settled_block = MESSAGES_JS[settled_pos : settled_pos + 500]
for block in (completion_block, settled_block):
assert "localStorage.setItem('hermes-webui-session',S.session.session_id);" in block
assert "_setActiveSessionUrl(S.session.session_id)" in block
assert "typeof _setActiveSessionUrl==='function'" in block