gooneyryan/hermes-webui
1
0
Fork 0
mirror of https://github.com/nesquena/hermes-webui.git synced 2026-05-25 19:20:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

stage-314 absorb: remove duplicate loadKanbanBoards tail call in loadKanban

Browse Source 
PR #1828 added an await loadKanbanBoards() at the START of loadKanban() to
resolve the active board before board-scoped requests fire (so a stale saved
slug can fall back to default cleanly). The existing tail-of-function refresh
at line 1278 was harmless under one-time loads but doubles /api/kanban/boards
traffic under SSE-driven refreshes (debounced at 250ms via
_scheduleKanbanRefresh). The 30-second polling interval started by
_kanbanStartPolling() picks up any board state changes that arrive after
the render, so the tail call is redundant in PR #1828's new model.

Per Opus pre-release verdict: SHIP with this perf cleanup as in-release
absorb (5 LOC delta, clearly defensive, no behavior change for the
single-load case).
This commit is contained in:
hermes-agent
2026-05-07 18:21:56 +00:00
parent d69d0eb35b
commit a1eec6d191
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/panels.js
+7 -4
View File
@@ -1272,10 +1272,13 @@ async function loadKanban(animate){
_kanbanSetSelectOptions($('kanbanAssigneeFilter'), _kanbanBoard.assignees || (assignees && assignees.assignees) || (config && config.assignees), 'kanban_all_assignees');
_kanbanSetSelectOptions($('kanbanTenantFilter'), _kanbanBoard.tenants, 'kanban_all_tenants');
await loadKanbanStats();
// Refresh the multi-board switcher (and resolve which board to show
// from localStorage / server state). Best-effort — failures hide the
// switcher rather than blocking the panel from rendering.
await loadKanbanBoards();
// Note: PR #1828 (v0.51.20) moved the boards refresh to the start of
// loadKanban() so the active board is resolved BEFORE board-scoped
// requests fire. The previous tail-of-function refresh has been removed
// to avoid doubling /api/kanban/boards traffic during SSE-driven
// refreshes (debounced at 250ms via _scheduleKanbanRefresh). The
// 30-second poll started by _kanbanStartPolling() picks up any board
// state changes that arrive after this render.
_kanbanStartPolling();
_kanbanRenderBoard();
} catch(e) {