Repository navigation
fix: check trim memory level in onTrimMemory() implementations - #1051
Merged
Merged
Conversation
Add a level >= TRIM_MEMORY_UI_HIDDEN check in GoogleMap and StreetView onTrimMemory() implementations to avoid unexpectedly trimming needed resources when TRIM_MEMORY_RUNNING_* levels are sent.
dkhawk
marked this pull request as ready for review
October 22, 2026 23:14
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
Contributor
Coverage (instrumentation tests)
Files
|
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a
level >= ComponentCallbacks2.TRIM_MEMORY_UI_HIDDENcheck toonTrimMemory()implementations inGoogleMapandStreetViewto avoid unexpectedly trimming needed resources whenTRIM_MEMORY_RUNNING_*is sent.Currently only
TRIM_MEMORY_UI_HIDDEN(20) andTRIM_MEMORY_BACKGROUND(40) are sent, butTRIM_MEMORY_RUNNING_CRITICAL(15) andTRIM_MEMORY_RUNNING_LOW(10) are being undeprecated.Verification
./gradlew :maps-compose:testDebugUnitTest./gradlew spotlessCheck./gradlew :maps-compose:lintDebug