Limit the number of segments a JWT can be exploded into.#639
Open
jeroen1602 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This avoids unneeded creation of memory for tokens that are invalid preventing a possible DOS. Added tests to verify these types of invalid tokens.
jeroen1602
force-pushed
the
limit-jwt-segments
branch
from
a21ece0 to
247d061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at CVE's for some go library that I use and came across CVE-2025-30204.
After looking at it I saw that this JWT library also has this issue so I decide to fix it.
When splitting the JWT into segments it now limits it to 4 segments max. Because after the 3rd segment the token is already invalid, so there is no need to split the token further. This avoids unneeded creation of memory for tokens that are invalid preventing a possible DOS.
I also added tests to verify these types of invalid tokens.