feat(sidekick/swift): improve snippet body#6434
Draft
coryan wants to merge 2 commits into
Draft
Conversation
Make the body more readable by using a single `.with{}` call for all the
fields.
For AIP-standard `Create*()` and `Update*()` requests we can show how
the body field is initialized.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Swift mustache template method_request_body.mustache to consolidate multiple .with block wrappers into a single outer .with block, and adds handling for ResourceIDField and non-message resource MessageFields. Feedback suggests simplifying the reference to {{MessageField.Codec.BaseFieldType}} to {{Codec.BaseFieldType}} since it is already inside the {{#MessageField}} context block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the body more readable by using a single
.with{}call for all the fields.For AIP-standard
Create*()andUpdate*()requests we can show how the body field is initialized.