feat(internal/librarian/java): remove redundant keep items in librarian.yaml#6291
Open
sofisl wants to merge 7 commits into
Open
feat(internal/librarian/java): remove redundant keep items in librarian.yaml#6291sofisl wants to merge 7 commits into
sofisl wants to merge 7 commits into
Conversation
sofisl
commented
Jun 3, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Tidy configuration functions across multiple languages (Java, Node.js, Python, and Rust) to accept a repoDir parameter. In Java, this parameter is used to determine if files in the keep configuration are manually maintained within GAPIC modules, preventing them from being incorrectly removed during the tidy process. Additionally, corresponding unit tests have been updated and a new test case TestTidy_ManualFiles has been added to verify this behavior. There are no review comments, so I have no feedback to provide.
sofisl
force-pushed
the
removeRedundantItems2TheStreets
branch
2 times, most recently
from
2843809 to
3077d0a
Compare
sofisl
commented
Jun 3, 2026
zhumin8
reviewed
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes redundant items in the
keepproperty in a librarian.yaml if it is inside gapic client module, and is a manual file. This PR also introduces a small refactor: since the Java clean.go also makes a determination whether a file is manual or not, this PR extracts that logic, creates a helper function, and then reuses it for our purposes as well.Fixes #6163