Skip to content

fix: preserve requestStream query params#1606

Open
pragnyanramtha wants to merge 1 commit into
googleapis:mainfrom
pragnyanramtha:codex/request-stream-query-params
Open

fix: preserve requestStream query params#1606
pragnyanramtha wants to merge 1 commit into
googleapis:mainfrom
pragnyanramtha:codex/request-stream-query-params

Conversation

@pragnyanramtha

Copy link
Copy Markdown

Summary

  • append HttpRequest.queryParams when building requestStream URLs
  • keep the streaming alt=sse default while preserving caller-provided params
  • update API client unit coverage for streaming query params and the second-request header assertion

Validation

  • npx tsc && cp src/cross/sentencepiece/sentencepiece_model.pb.js dist/src/cross/sentencepiece/ && npx jasmine dist/test/unit/api_client_test.js
  • npx eslint src/_api_client.ts test/unit/api_client_test.ts
  • npx prettier --check src/_api_client.ts test/unit/api_client_test.ts
  • npm run unit-test
  • git diff --check

@pragnyanramtha pragnyanramtha force-pushed the codex/request-stream-query-params branch from 6e0890f to 44607a7 Compare May 17, 2026 05:12
@pragnyanramtha pragnyanramtha changed the title fix requestStream query params fix: preserve requestStream query params May 17, 2026
@pragnyanramtha pragnyanramtha marked this pull request as ready for review May 17, 2026 05:13
@pragnyanramtha pragnyanramtha force-pushed the codex/request-stream-query-params branch from 24fbaf4 to a3d9697 Compare May 21, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant