Skip to content

fix: honor request-level retry options#1605

Open
pragnyanramtha wants to merge 1 commit into
googleapis:mainfrom
pragnyanramtha:codex/request-retry-options
Open

fix: honor request-level retry options#1605
pragnyanramtha wants to merge 1 commit into
googleapis:mainfrom
pragnyanramtha:codex/request-retry-options

Conversation

@pragnyanramtha

Copy link
Copy Markdown

Summary

  • use the merged request HTTP options when deciding whether to retry API calls
  • preserve client-level retry behavior while enabling per-request retryOptions for unary and streaming requests
  • add unit coverage for request-level retry and request override behavior

Why

request() and requestStream() already merge client and request httpOptions, but apiCall() only read this.clientOptions.httpOptions.retryOptions. As a result, httpOptions.retryOptions supplied for a single request was ignored.

Validation

  • npm ci (runs the repository prepare/build script)
  • npx prettier src/_api_client.ts test/unit/api_client_test.ts --write
  • npx eslint src/_api_client.ts test/unit/api_client_test.ts
  • npx tsc && npx jasmine dist/test/unit/api_client_test.js
  • npm run unit-test
  • git diff --check

@pragnyanramtha pragnyanramtha changed the title [codex] fix request-level retry options fix: honor request-level retry options May 16, 2026
@pragnyanramtha pragnyanramtha force-pushed the codex/request-retry-options branch from f83e491 to 4c4b6ea Compare May 16, 2026 21:54
@pragnyanramtha pragnyanramtha marked this pull request as ready for review May 16, 2026 22:01
@pragnyanramtha pragnyanramtha force-pushed the codex/request-retry-options branch from 4a4e7df to cd5af5f Compare May 21, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant