feat(sidekick/rust): generate rust code for discovery LROs error extraction#5861
Closed
haphungw wants to merge 1 commit into
Closed
feat(sidekick/rust): generate rust code for discovery LROs error extraction#5861haphungw wants to merge 1 commit into
haphungw wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the tracing implementation across numerous generated service clients. It replaces direct thread-local access of POLL_ATTEMPT_COUNT with the google_cloud_lro::record_polling_attributes! macro to record long-running operation (LRO) polling attributes on spans. Additionally, it updates the check for active LRO recording to use google_cloud_lro::LroRecorder::current().is_some(). I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5861 +/- ##
==========================================
- Coverage 97.89% 97.89% -0.01%
==========================================
Files 226 226
Lines 57808 57808
==========================================
- Hits 56592 56591 -1
- Misses 1216 1217 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage the generated code from googleapis/librarian#6304